Self-cert SSL for local https #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Improved readability of `fullSetup.sh` - Added logic to create self-cert SSL when running locally. This is needed to support testing with http/2
- Created `docker-compose` file for self-cert testing
- Improved `fullSetup.sh` - Fixed `local.conf` - `docker-compose-local.yml` now starts up correctly. `curl -I --http2 -k https://localhost` shows that http/2 is working as expected
- Updated syntax for Docker network
- Improved logic for setting `/etc/sysctl.conf` settings
- Docker is no longer reinstalled when running `fullSetup.sh` multiple times
- Local Nginx config updated to proxy_pass to the correct container. Now the local development UI uses http/2 when the URL is `https://localhost` (note that we don't include the port)!
- Docker testing container is now removed after we verify that the Docker engine is working correctly
- local Nginx config updated to use variables for DNS resolution, which should help ensure that Nginx works even when started before the app's containers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repo has been updated to include a local development setup. This creates a self-signed SSL certificate, and has Nginx use that instead of a real one.
NOTE 1: When navigating to your URL, make sure to use
https://localhost. Do not include the port! If you navigate tohttp://localhost:3000, it should work as normal (but will use the http/1.1 protocol instead of http/2)NOTE 2: The current
local.confsetup relies on aproxy_passto the UI container and port. These are hard-coded touiand3000, so you may have to change these if needed