-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for string formats; fix at-identifier
format
#491
Conversation
2359e6e
to
4e97cc8
Compare
b27b890
to
d1eaf42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove redundant type info dont interfere w docstring
try again jeez try to fix spacing
no markdown i guess
d8f75c5
to
b63171b
Compare
clean up a couple things
4c5e52c
to
967a9c6
Compare
eureka!
1fd79c3
to
7e97961
Compare
@MarshalX alright I have
on the last point, the best way I could immediately find to deal with this was to switch to using while the address present is midly annoying to me, showing the function name makes some sense to me as the constraint really is arbitrary logic that may exist in that function. let me know if you see a more reasonable path forward on this! |
7e97961
to
0f6168e
Compare
great @MarshalX ! sounds good |
at-identifier
format
@zzstoatzz i fixed some stuff; pls check and confirm is all good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! lgtm
thank you! |
closes #478
this PR adds:
docstrings to all validator functions
a new docs page,
string_formats.md
improved rendering of string format contstraints, as discussed below