Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Make strikes persistent [PR welcome] #219

Open
ToasterUwU opened this issue Dec 18, 2024 · 3 comments
Open

[Feature Request] Make strikes persistent [PR welcome] #219

ToasterUwU opened this issue Dec 18, 2024 · 3 comments

Comments

@ToasterUwU
Copy link

I looked for a way to do this, couldnt find anything. So im pretty sure this isnt a thing yet.

I would like to see a way to make the progress of the strikes persistent across restarts and even remaking of the container.

Im trying to download very niche things sometimes, so i set my strikes to an amount that last 3 days. I cant rely on their being loots of torrents out there, so i have to rely on giving the few that do exist all the time they might need.

Issue is that if i restart my server within 3 days, or an update for the containers gets applied, or i change my setup slightly and have to restart all containers because of it, the 288 max strikes get reset. At this rate it will never reach the limit and never actually do anything.

Prefered solution would be something simple like a file saved somewhere in the container so that making a bind volume to that location makes the progress data persist across even removing and remaking the container.

@ToasterUwU ToasterUwU changed the title Make strikes persistent [Feature Request] Make strikes persistent Dec 18, 2024
@ToasterUwU
Copy link
Author

Im also happy to do this myself via PR if that would be welcome. I dont have time rn, but i should find some if i have to before new years.

@ManiMatter
Copy link
Owner

Hi

this feature has been asked a couple of times but I dont have time either.

my initial thought is that the classes that track the strike write to a file. And when the script/container restarts, the init reads the file to get the history. We add a setting that can turn on/off this tracking between „reboots“

if you want to have a go, please feel free. Not planning of adding it myself

@ManiMatter ManiMatter changed the title [Feature Request] Make strikes persistent [Feature Request] Make strikes persistent [PR welcome] Dec 18, 2024
@ToasterUwU
Copy link
Author

Yeah I was thinking the same thing basically. A json file of torrent hash key and strike integer would be more than good enough.

I will take a look when I get the time and probably implement it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants