Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/3674/show labels broken #3907

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

BenediktMehl
Copy link
Collaborator

@BenediktMehl BenediktMehl commented Feb 3, 2025

if show labels in height options is unselected, selecting show labels in color options doesn't change anything

Closes: #3674

Description

I added an effect, that checks "show labels" in height options if "show labels" in color options is checked.
Also removes "show labels" in height option, if "show labels" in color options is unchecked.
Still this whole interaction is weird. All "show labels"-option should be moved to one place.

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

  • Changes have been manually tested
  • All TODOs related to this PR have been closed
  • There are automated tests for newly written code and bug fixes
  • All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
  • Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
  • CHANGELOG.md has been updated

Screenshots or gifs

@BenediktMehl BenediktMehl force-pushed the bug/3674/show-labels-broken branch from b9ecf54 to f8a15ab Compare February 3, 2025 10:34
Copy link

sonarqubecloud bot commented Feb 3, 2025

Copy link

sonarqubecloud bot commented Feb 3, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Show labels" in Color Metric Options not working
1 participant