Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix logging of systeminformation for raspberry pi #3505

Open
khassel opened this issue Jul 22, 2024 · 4 comments
Open

fix logging of systeminformation for raspberry pi #3505

khassel opened this issue Jul 22, 2024 · 4 comments

Comments

@khassel
Copy link
Collaborator

khassel commented Jul 22, 2024

Our systeminformation on startup on a raspberry pi:

[2024-07-22 21:03:15.102] [INFO]  System information:
### SYSTEM:   manufacturer: Raspberry Pi Foundation; model: Raspberry Pi 4 Model B Rev 1.5; raspberry: [object Object]; virtual: false
### OS:       platform: linux; distro: Debian GNU/Linux; release: 12; arch: arm64; kernel: 6.1.21-v8+
### VERSIONS: electron: 31.2.1; used node: 20.15.0; installed node: 22.4.1; npm: 10.8.1; pm2:
### OTHER:    timeZone: Europe/Berlin; ELECTRON_ENABLE_GPU: undefined

So the object raspberry: [object Object] should be corrected. Using JSON.stringify results in

{"manufacturer":"Sony UK","processor":"BCM2711","type":"4B","revision":"1.5"}

Options:

  • we use JSON.stringify and add the info to the line
  • we omit these infos because they are not of interest
  • ?

I'm for removing the object, what do you think @sdetweil @rejas @KristjanESPERANTO ?

@khassel khassel added the bug label Jul 22, 2024
@rejas
Copy link
Collaborator

rejas commented Jul 22, 2024

I'd go for the stringify

@KristjanESPERANTO
Copy link
Contributor

I don't know if the information is really helpful, the information in the model field seems to be enough. From my point of view, we could remove it.

If we do stringify, the line will be too long, so we should add a line break somewhere. Maybe like this:

[2024-07-22 21:03:15.102] [INFO]  System information:
### SYSTEM:    manufacturer: Raspberry Pi Foundation; model: Raspberry Pi 4 Model B Rev 1.5; virtual: false
### raspberry: "manufacturer":"Sony UK","processor":"BCM2711","type":"4B","revision":"1.5"
### OS:        platform: linux; distro: Debian GNU/Linux; release: 12; arch: arm64; kernel: 6.1.21-v8+
### VERSIONS:  electron: 31.2.1; used node: 20.15.0; installed node: 22.4.1; npm: 10.8.1; pm2:
### OTHER:     timeZone: Europe/Berlin; ELECTRON_ENABLE_GPU: undefined

@sdetweil
Copy link
Collaborator

i'm for removing... not really adding any useful info

@rejas
Copy link
Collaborator

rejas commented Jul 28, 2024

ok, then lets remove it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants