-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple Instances of Node Helper running for a single module #3502
Comments
I encountered the same bug while trying to understand why a module was not working properly and there a broadcast storm of WS messages. Is this a regression from the original behavior or was it always like this? |
I found the issue: |
we changed to allowing an async process from mode_helper.start |
This was referenced Aug 12, 2024
rejas
pushed a commit
that referenced
this issue
Aug 18, 2024
…3523) - [x] Base your pull requests against the `develop` branch. - [x] Include these infos in the description: > - Does the pull request solve a **related** issue? Yes - solves #3521 > - If so, can you reference the issue like this `Fixes #<issue_number>`? Fixes #3521 (also mentioned in commit message) > - What does the pull request accomplish? Use a list if needed. > > - Updates duplicate module filter method (upstream vs downstream - see #3502) > > - Updates socket io catchall functionality to new API [[docs](https://socket.io/docs/v4/listening-to-events/)]. - [x] Please run `npm run lint:prettier` before submitting - [x] Don't forget to add an entry about your changes to the CHANGELOG.md file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I found a bug in MagicMirror
Platform: Electron version 31.1.0 running on Windows (reproducible on both Windows 10 and Windows 11)
Node Version: v20.15.1
MagicMirror² Version: 2.28.0
Description:
There are a couple of modules my mirror that are repeated, to be configured with different module level settings. I'm seeing instances of multiple node helpers being created for the repeated modules, which is leading to unnecessary noise in communication between the modules and the node helpers.
It's my understanding that there should only be one instance of a node helper per module type. From the Module Development Documentation:
Here's the output from the command line with two instances of the MMM-GoogleCalendar module in the config file
Each instance of the module seems to be loading it's own version of the node helper.
Reading through the initialization code, I'm not seeing anything preventing duplicate node helpers from being started. I think the answer might be as simple as removing duplicates from the module list before loading them? We could just use a Set to remove any duplicates from the modules array:
Or prevent duplicates from being added to the array further upstream, but this would just be a one-liner fix.
The text was updated successfully, but these errors were encountered: