Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pre-commit-hooks: replace black and flake8 #232

Closed
afuetterer opened this issue Jun 8, 2024 · 2 comments
Closed

pre-commit-hooks: replace black and flake8 #232

afuetterer opened this issue Jun 8, 2024 · 2 comments

Comments

@afuetterer
Copy link
Contributor

Would you like to change black and flake8 to ruff-format and ruff-lint in your pre-commit-config.yaml?

See MaartenGr/BERTopic#2033
@MaartenGr
Copy link
Owner

Yes! If possible, maintaining similar formats between packages would be preferred as both packages share a similar user base.

@afuetterer
Copy link
Contributor Author

Alright, let me propose a PR then. Will do that soon.

@afuetterer afuetterer mentioned this issue Jun 24, 2024
Merged
@afuetterer afuetterer changed the title pre-commit-hooks: replace black and flake8? pre-commit-hooks: replace black and flake8 Jun 24, 2024
@afuetterer afuetterer mentioned this issue Jun 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MaartenGr @afuetterer