From 4f6f9f0deb30d229fcd4a022015ecc7ea3ac1bda Mon Sep 17 00:00:00 2001 From: Moealfadil <142026026+Moealfadil@users.noreply.github.com> Date: Thu, 9 Jan 2025 20:05:58 +0200 Subject: [PATCH] Revert "Merge branch 'main' into crafting_retrospective" This reverts commit 04aa0b86013ee0f076c8a622611d0d3e00c2bad5, reversing changes made to 550d65a3bfd1a35e6eda9a7fa58a32b1866f8e55. --- .github/PULL_REQUEST_TEMPLATE.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index eba8a7be2..eb18b4638 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -54,7 +54,6 @@ about: A template PR for code review with a checklist - [ ] The function's name describes it's behavior - [ ] The function's name matches the file name - - _It's ok to have extra helper functions if necessary, like with mergesort_ - [ ] The function has correct type annotations - [ ] The function is not called at the top level of the function file - _Recursive solutions **can** call the function from **inside** the function body_ @@ -69,7 +68,7 @@ about: A template PR for code review with a checklist ### Don'ts -- [ ] The function's strategy _is not_ described in any docstrings or tests +- [ ] The function's strategy _is not_ described in the documentation - [ ] Comments explain the _strategy_, **not** the _implementation_ - [ ] The function _does not_ have more comments than code - If it does, consider finding a new strategy or a simpler implementation