Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stretch augmentation simplified via dseg search? #134

Open
Luke-Poeppel opened this issue May 13, 2021 · 0 comments
Open

Stretch augmentation simplified via dseg search? #134

Luke-Poeppel opened this issue May 13, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request Improvement Improvement to speed or code complexity

Comments

@Luke-Poeppel
Copy link
Owner

Luke-Poeppel commented May 13, 2021

It seems that a far simpler solution to the current stretch_augment implementation in hash_table.py would be simplified by migrating this to rolling_hash_search and using the dseg (or retrograde of it). At that point, it would
probably be wise to implement the FragmentHashTable.get_by_ql_array that migrates the more complicated modification search methods (like subdivision, contiguous summation, etc.).

In this new implementation (some time after v1.0.0), I would do a simple dseg search and then run the calculation after the fact for tracking in the Extraction.

@Luke-Poeppel Luke-Poeppel added enhancement New feature or request Improvement Improvement to speed or code complexity labels May 13, 2021
@Luke-Poeppel Luke-Poeppel self-assigned this May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Improvement Improvement to speed or code complexity
Projects
None yet
Development

No branches or pull requests

1 participant