Unable to ignore applying only one library

[carsakiller]

How are you using the lua-language-server?

Visual Studio Code Extension (sumneko.lua)

Which OS are you using?

Windows

What is the issue affecting?

Libraries

Expected Behaviour

When multiple libraries are detected, the user should be able to tell the server to stop asking to apply a specific library, and continue receiving suggestions for other libraries.

Actual Behaviour

Once the user selects “Don't show again”, workspace.checkThirdParty is set to false, preventing any suggestions from appearing.

Reproduction steps

1. Enter the following in a file to trigger library detection:

   local assert = require("luassert")
   
   resty.a
   
   love.a

2. When the “Apply library” popup appears, press “Don't show again”
3. Try to automatically apply one of the other libraries automatically.

Additional Notes

A similar issue was resolved in v3.6.0 which allowed the server to continue recommending libraries when one was applied, but this issue is about when a user does not apply the suggested library.

Maybe it would make sense to create a new setting called workspace.libraryIgnore that is an array of ignored libraries. Then workspace.checkThirdParty can remain for backwards compatibility and so all suggestions can be disabled.

Log File

No response

[justarandomgeek]

I would add to this, a setting such as workspace.libraryApply that is an array of libraries (by name, ideally) to apply without prompting, even if general prompts are disabled.

[prescientmoon]

I'm also in support of this :O