Nested property type lost when accessed from reference

[lunarwtr]

How are you using the lua-language-server?

Visual Studio Code Extension (sumneko.lua)

Which OS are you using?

Windows

What is the issue affecting?

Type Checking

Expected Behaviour

	local A = {}

	---@class B
	---@overload fun(): B
	local B = {}

	---@class C
	---@overload fun(): C
	local C = {}

	A.property1 = B()

	A.property1.property2 = C()

	local refToB = A.property1

	local refToC = refToB.property2

while the local refToB is correctly of type B, it no longer is aware of property2.

expected behavior would be that it is aware of the properties assigned to the instance.

Actual Behaviour

presence of property is lost in the "instance" of object B (not definition).

Reproduction steps

1. Go to '...'
2. Click '...'
3. See error '...'

Additional Notes

No response

Log File

No response

[carsakiller]

Related: #1561

[sumneko]

You can not inject fields in this way, use the follow way instead.

---@class B
local B = {}

B.property2 = C()

[lunarwtr]

that was just the example, but this sort of behavior manifests itself when you use a reference to a property regardess of how injected field is done.

A.property1.property2 <--- correctly knows property or type...

Here is another example.

test(A.property1)

function test( ref )
ref.property2 <-- unknown
end

[lunarwtr]

this happens for me when I have a deeply nested property, then want to use a reference to make code smaller / clean vs always using the full. please consider taking closer look.

[sumneko]

You can change your code to

local A = {}

---@class B
---@overload fun(): B
local B = {}

---@class C
---@overload fun(): C
local C = {}

---@class B --> add this annotation
A.property1 = B()

A.property1.property2 = C()

local refToB = A.property1

local refToC = refToB.property2

[carsakiller]

@lunarwtr has your issue been resolved?

[lunarwtr]

Kind of.. I can apply type annotations in every function, but that is not ideal. None the less I appreciate your work on this.

Here is real example..

In constructor define something.. typing looks perfect.

Then in all other functions type is lost. I can do as sumneko suggests and reassign the unknown to a variable with typing.

[Mailaender]

The type is also lost when inside a table. OpenRA/vscode-openra-lua#10