Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dependency Security Checks #21

Open
james-alt opened this issue Apr 4, 2018 · 7 comments
Open

Add Dependency Security Checks #21

james-alt opened this issue Apr 4, 2018 · 7 comments

Comments

@james-alt
Copy link
Contributor

More of a discussion point, but what do you think of adding something like Snyk to keep up with the dependencies we are using and especially those we are adding and making sure we aren't using something with a known security vulnerability.

I know it's probably not a real concern, based on the scope of what we are doing, but all in all not a hard thing to do.

I can set this up, but I would need to be made an admin on the repo, otherwise someone else could easily create a free account on their website and add it in.

@ngscheurich
Copy link
Collaborator

I'm on board with this 👍. If @adamculpepper wants to make you an admin, I'm good with you getting it set up.

@adamculpepper
Copy link
Member

@james-alt At this point, this project is more @ngscheurich's. 😃
Whatever @ngscheurich wants, @ngscheurich gets.

@adamculpepper
Copy link
Member

@james-alt permissions updated to Admin level.

@adamculpepper
Copy link
Member

Yea, didn't mean to close the issue. @james-alt you should be good to go now.

@james-alt
Copy link
Contributor Author

All good @adamculpepper. I've gone ahead and added Snyk to the project and I'm letting it test. I'll close the issue once the test is done and I've added the super cool badge to our README

@ngscheurich
Copy link
Collaborator

It's all about those sweet, sweet badges.

@james-alt
Copy link
Contributor Author

There are a couple of security vulnerabilities listed, but they don't seem to necessarily have a fix for them at the moment. I'll try and add everyone to the group so you can see them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants