Improve AppIndicator and D-Bus validation in desktop setup

Adds a debug script for AppIndicator environment, enhances D-Bus session detection and validation in setup and post-CI scripts, and improves AppIndicator service checks. These changes provide better diagnostics and reliability for virtual desktop environments using MATE/XFCE.

Author: ReenigneArcher

actions/setup_virtual_desktop/action.yml

@@ -133,10 +133,18 @@ runs:
         echo "::group::Test AppIndicator"
         # Test ayatana-appindicator (only on MATE/XFCE which have indicator support)
         if [[ "$ENVIRONMENT" == "mate" ]] || [[ "$ENVIRONMENT" == "xfce" ]]; then
-          python3 "${GITHUB_ACTION_PATH}/test_appindicator.py" &
-          APPIND_PID=$!
-          ${SCREENSHOT_PATH} --output-path=05-appindicator.png --delay=1000
-          kill $APPIND_PID 2>/dev/null || true
+          echo "::group::AppIndicator Debug Info"
+          bash "${GITHUB_ACTION_PATH}/debug_indicators.sh"
+          echo "::endgroup::"
+
+          echo "Testing AppIndicator support..."
+          if python3 "${GITHUB_ACTION_PATH}/test_appindicator.py"; then
+            echo "AppIndicator test completed successfully"
+            ${SCREENSHOT_PATH} --output-path=05-appindicator.png --delay=500
+          else
+            echo "::error::AppIndicator test failed"
+            exit 1
+          fi
         else
           echo "Skipping AppIndicator test (not supported on ${ENVIRONMENT})"
         fi

actions/setup_virtual_desktop/debug_indicators.sh

@@ -0,0 +1,49 @@
+#!/bin/bash
+# Debug script to check AppIndicator environment
+
+echo "=== AppIndicator Debug Information ==="
+echo ""
+
+echo "1. Checking if indicator service is running:"
+ps aux | grep -E "(ayatana-indicator|indicator-application)" | grep -v grep || echo "  No indicator service found"
+echo ""
+
+echo "2. Checking D-Bus session:"
+echo "  DBUS_SESSION_BUS_ADDRESS: ${DBUS_SESSION_BUS_ADDRESS:-NOT SET}"
+echo ""
+
+echo "3. Checking if indicator service is on D-Bus:"
+dbus-send --session --dest=org.freedesktop.DBus --print-reply /org/freedesktop/DBus \
+  org.freedesktop.DBus.ListNames 2>/dev/null | grep -i indicator || echo "  No indicator service registered on D-Bus"
+echo ""
+
+echo "4. Checking GObject Introspection typelibs:"
+if [ -f "/usr/lib/x86_64-linux-gnu/girepository-1.0/AyatanaAppIndicator3-0.1.typelib" ]; then
+  echo "  ✓ AyatanaAppIndicator3-0.1.typelib found"
+else
+  echo "  ✗ AyatanaAppIndicator3-0.1.typelib NOT found"
+fi
+echo ""
+
+echo "5. Checking panel processes:"
+ps aux | grep -E "(mate-panel|xfce4-panel)" | grep -v grep || echo "  No panel found"
+echo ""
+
+echo "6. Checking DISPLAY:"
+echo "  DISPLAY: ${DISPLAY:-NOT SET}"
+echo ""
+
+echo "7. Testing simple indicator registration:"
+python3 -c "
+import gi
+gi.require_version('AyatanaAppIndicator3', '0.1')
+from gi.repository import AyatanaAppIndicator3 as AppIndicator
+print('  ✓ Python can import AyatanaAppIndicator3')
+indicator = AppIndicator.Indicator.new('test', 'mail-message-new', AppIndicator.IndicatorCategory.APPLICATION_STATUS)
+print('  ✓ Created indicator object')
+indicator.set_status(AppIndicator.IndicatorStatus.ACTIVE)
+print('  ✓ Set indicator status to ACTIVE')
+" 2>&1 || echo "  ✗ Failed to create indicator"
+
+echo ""
+echo "=== End Debug Information ==="

actions/setup_virtual_desktop/post-ci.sh

@@ -12,6 +12,25 @@ fi
 
 echo "✓ DISPLAY is set to: $DISPLAY"
 
+# Check D-Bus session address is set
+echo ""
+echo "Checking D-Bus session..."
+if [[ -z "${DBUS_SESSION_BUS_ADDRESS:-}" ]]; then
+  echo "✗ DBUS_SESSION_BUS_ADDRESS is not set"
+  exit 1
+fi
+
+echo "✓ DBUS_SESSION_BUS_ADDRESS is set to: $DBUS_SESSION_BUS_ADDRESS"
+
+# Verify D-Bus is working
+if dbus-send --session --dest=org.freedesktop.DBus --print-reply /org/freedesktop/DBus \
+   org.freedesktop.DBus.ListNames >/dev/null 2>&1; then
+  echo "✓ D-Bus session is responding"
+else
+  echo "✗ D-Bus session is not responding"
+  exit 1
+fi
+
 # Check if X server is responding
 if xdpyinfo > /dev/null 2>&1; then
   echo "✓ X server is responding"
@@ -77,5 +96,24 @@ if [[ "$PANEL_FOUND" = false ]]; then
   exit 1
 fi
 
+# Check for AppIndicator service (MATE/XFCE only)
+echo ""
+echo "Checking for AppIndicator service..."
+if pgrep -f "ayatana-indicator-application-service" > /dev/null 2>&1; then
+  echo "✓ AppIndicator service is running"
+
+  # Verify it's registered on D-Bus
+  if dbus-send --session --dest=org.freedesktop.DBus --print-reply /org/freedesktop/DBus \
+     org.freedesktop.DBus.ListNames 2>/dev/null | grep -q "com.canonical.indicator.application"; then
+    echo "✓ AppIndicator service is registered on D-Bus"
+  else
+    echo "⚠ AppIndicator service running but not registered on D-Bus"
+  fi
+elif pgrep -x "mate-session" > /dev/null 2>&1 || pgrep -x "xfce4-session" > /dev/null 2>&1; then
+  echo "⚠ MATE/XFCE session detected but AppIndicator service not running"
+else
+  echo "ℹ AppIndicator service not expected (not MATE/XFCE environment)"
+fi
+
 echo ""
 echo "Virtual desktop validation successful!"

actions/setup_virtual_desktop/setup_desktop.sh

@@ -207,6 +207,52 @@ echo -e "${BLUE}Starting D-Bus session...${RESET}"
 if ! pgrep -x "dbus-daemon" > /dev/null; then
   eval "$(dbus-launch --sh-syntax)"
   echo "DBUS_SESSION_BUS_ADDRESS=$DBUS_SESSION_BUS_ADDRESS" >> "$GITHUB_ENV"
+  echo -e "${GREEN}✓ D-Bus session started${RESET}"
+else
+  echo -e "${YELLOW}⚠ D-Bus daemon already running${RESET}"
+fi
+
+# Ensure DBUS_SESSION_BUS_ADDRESS is set and exported
+if [[ -z "${DBUS_SESSION_BUS_ADDRESS:-}" ]]; then
+  echo -e "${YELLOW}⚠ DBUS_SESSION_BUS_ADDRESS not set, attempting to detect...${RESET}"
+
+  # Find the dbus-daemon process for the current user
+  DBUS_PID=$(pgrep -u "$(id -u)" dbus-daemon | head -n 1)
+
+  if [[ -n "$DBUS_PID" ]]; then
+    echo -e "${CYAN}Found dbus-daemon PID: ${DBUS_PID}${RESET}"
+
+    # Extract DBUS_SESSION_BUS_ADDRESS from the process environment
+    # Disable pipefail temporarily for this command since grep may not find the variable
+    set +e
+    DBUS_ADDR=$(grep -z DBUS_SESSION_BUS_ADDRESS "/proc/$DBUS_PID/environ" 2>/dev/null | tr '\0' '\n' | cut -d= -f2-)
+    GREP_EXIT=$?
+    set -e
+
+    if [[ -n "$DBUS_ADDR" ]]; then
+      echo -e "${GREEN}✓ Detected D-Bus session address${RESET}"
+      export DBUS_SESSION_BUS_ADDRESS="$DBUS_ADDR"
+      echo "DBUS_SESSION_BUS_ADDRESS=$DBUS_ADDR" >> "$GITHUB_ENV"
+    else
+      echo -e "${YELLOW}Debug: grep exit code: ${GREP_EXIT}${RESET}"
+      echo -e "${YELLOW}Debug: Checking /proc/$DBUS_PID/environ exists...${RESET}"
+      if [[ -f "/proc/$DBUS_PID/environ" ]]; then
+        echo -e "${YELLOW}Debug: File exists, dumping environment variables:${RESET}"
+        cat "/proc/$DBUS_PID/environ" | tr '\0' '\n' | grep -i dbus || true
+      else
+        echo -e "${RED}Error: /proc/$DBUS_PID/environ not found${RESET}" >&2
+      fi
+      echo -e "${RED}Error: Could not extract D-Bus address from process environment${RESET}" >&2
+      exit 1
+    fi
+  else
+    echo -e "${RED}Error: dbus-daemon process not found${RESET}" >&2
+    exit 1
+  fi
+else
+  echo -e "${GREEN}✓ DBUS_SESSION_BUS_ADDRESS is set${RESET}"
+  # Ensure it's in GITHUB_ENV even if already set in current shell
+  echo "DBUS_SESSION_BUS_ADDRESS=$DBUS_SESSION_BUS_ADDRESS" >> "$GITHUB_ENV"
 fi
 
 # Start AT-SPI bus to fix accessibility warnings