Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimal tests #18

Open
3 tasks
davanstrien opened this issue Jun 28, 2021 · 1 comment
Open
3 tasks

Add minimal tests #18

davanstrien opened this issue Jun 28, 2021 · 1 comment
Assignees
Milestone

Comments

@davanstrien
Copy link
Member

It would be good to add at least minimal tests before releasing this publicly

Things to test

  • e2e XML produces expected metadata fields
  • cli
  • ???

There may be some opportunities for refactoring to allow for some more unit tests

@andrewphilipsmith
Copy link
Contributor

andrewphilipsmith commented Apr 5, 2022

I just had a discussion with @fedenanni and @thobson88 about this.
Our notes are here https://hackmd.io/KeOzeaMYTOiF37pGUjUl7A

We suggested these initial tests:

  • Does the output file contain the correct text for a known input file?
  • Does alto2txt report correctly report the number of input files that have been processed?
  • Does alto2txt count the number of articles in a METS file correctly?
  • Does the number of articles found in the (METS file), match the number of output files?
  • Does alto2txt throw an error if there are ALTO files missing that are described in a METS file?
  • Does alto2txt throw an error if there are orphaned ALTO files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants