From 6a9cb14f5c903c643283d9492f744fb7b9fcfbcf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mona=20B=C3=A4renf=C3=A4nger?= Date: Wed, 20 Nov 2024 10:45:46 +0100 Subject: [PATCH 1/3] Apply suggestions from code review Co-authored-by: Sameer --- docs/building-on-lisk/using-oracle-data/tellor.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/building-on-lisk/using-oracle-data/tellor.md b/docs/building-on-lisk/using-oracle-data/tellor.md index 9030ce87b..61750747c 100644 --- a/docs/building-on-lisk/using-oracle-data/tellor.md +++ b/docs/building-on-lisk/using-oracle-data/tellor.md @@ -119,7 +119,7 @@ contract MyContract is UsingTellor { { // retrieve the most recent 20+ minute old ETH price. // the buffer allows time for a bad value to be disputed - (bytes memory _data, uint256 _timestamp) = getDataBefore(ethQueryId, block.timestamp - DISPUTE_BUFFER); + (bytes memory _data, uint256 _timestamp) = _getDataBefore(ethQueryId, block.timestamp - DISPUTE_BUFFER); // check whether any value was retrieved if (_timestamp == 0 || _data.length == 0) revert NoValueRetrieved(_timestamp); @@ -160,7 +160,7 @@ contract MyContract is UsingTellor { uint256 timestamp ) { - (bytes memory _data, uint256 _timestamp) = getDataBefore(lskQueryId, block.timestamp - DISPUTE_BUFFER); + (bytes memory _data, uint256 _timestamp) = _getDataBefore(lskQueryId, block.timestamp - DISPUTE_BUFFER); if (_timestamp == 0 || _data.length == 0) revert NoValueRetrieved(_timestamp); From 52f17df0eb8a582d1e67e7ded9cd045bb8c5b895 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mona=20B=C3=A4renf=C3=A4nger?= Date: Wed, 20 Nov 2024 11:03:05 +0100 Subject: [PATCH 2/3] Apply suggestions from code review Co-authored-by: Sameer --- docs/building-on-lisk/using-oracle-data/tellor.md | 2 +- docs/lisk-tools/oracles.md | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/building-on-lisk/using-oracle-data/tellor.md b/docs/building-on-lisk/using-oracle-data/tellor.md index 61750747c..7584110ed 100644 --- a/docs/building-on-lisk/using-oracle-data/tellor.md +++ b/docs/building-on-lisk/using-oracle-data/tellor.md @@ -22,7 +22,7 @@ keywords: [ # Using oracle data with Tellor [Tellor](https://tellor.io/) is an immutable decentralized oracle protocol where parties can request the value of an offchain data point (e.g. ETH/USD, LSK/USD) and reporters compete to add this value to an onchain databank. -The inputs to this data-bank are secured by a network of staked reporters. +The inputs to this databank are secured by a network of staked reporters. Tellor utilizes crypto-economic incentive mechanisms, rewarding honest data submissions by reporters and punishing bad actors through the issuance of Tellor’s token, Tributes (TRB) and a dispute mechanism. diff --git a/docs/lisk-tools/oracles.md b/docs/lisk-tools/oracles.md index a0739e9c0..769e36dfd 100644 --- a/docs/lisk-tools/oracles.md +++ b/docs/lisk-tools/oracles.md @@ -48,8 +48,8 @@ Interested in integration? [Get in contact](https://discord.com/invite/PVxBZKFr4 ## Tellor -Tellor is an immutable decentralized oracle protocol where parties can request the value of an off-chain data point (e.g. ETH/USD) and reporters compete to add this value to an on-chain data-bank. -The inputs to this data-bank are secured by a network of staked reporters. +Tellor is an immutable decentralized oracle protocol where parties can request the value of an offchain data point (e.g. ETH/USD) and reporters compete to add this value to an onchain databank. +The inputs to this databank are secured by a network of staked reporters. Tellor utilizes crypto-economic incentive mechanisms, rewarding honest data submissions by reporters and punishing bad actors through the issuance of Tellor’s token, Tributes (TRB) and a dispute mechanism. From d993a1d65269b6708fd8517cdbd265ed969ed52b Mon Sep 17 00:00:00 2001 From: Tschakki Date: Wed, 20 Nov 2024 11:05:08 +0100 Subject: [PATCH 3/3] Fix links --- docs/building-on-lisk/using-oracle-data/redstone-pull.md | 4 ++-- docs/building-on-lisk/using-oracle-data/tellor.md | 5 ++--- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/docs/building-on-lisk/using-oracle-data/redstone-pull.md b/docs/building-on-lisk/using-oracle-data/redstone-pull.md index 351c8b30c..2c24b7b9c 100644 --- a/docs/building-on-lisk/using-oracle-data/redstone-pull.md +++ b/docs/building-on-lisk/using-oracle-data/redstone-pull.md @@ -158,5 +158,5 @@ Latest ETH price: To deploy the smart contract on Lisk Sepolia or Lisk Mainnet, follow the guides -- [Deploying a smart contract with Hardhat](../deploying-smart-contract/with-Hardhat.md), or -- [Deploying a smart contract with Foundry](../deploying-smart-contract/with-Foundry.md) \ No newline at end of file +- [Deploying a smart contract with Hardhat](../deploying-smart-contract/with-Hardhat), or +- [Deploying a smart contract with Foundry](../deploying-smart-contract/with-Foundry) \ No newline at end of file diff --git a/docs/building-on-lisk/using-oracle-data/tellor.md b/docs/building-on-lisk/using-oracle-data/tellor.md index 7584110ed..99b7f1dbb 100644 --- a/docs/building-on-lisk/using-oracle-data/tellor.md +++ b/docs/building-on-lisk/using-oracle-data/tellor.md @@ -195,9 +195,8 @@ For a general overview of best practices using Tellor, go to the [User checklist To deploy the smart contract on Lisk Sepolia or Lisk Mainnet, follow the guides -- [Deploying a smart contract with Hardhat](../deploying-smart-contract/with-Hardhat.md), or -- [Deploying a smart contract with Foundry](../deploying-smart-contract/with-Foundry.md) -- [Deploying a smart contract with Foundry](../deploying-smart-contract/with-Hardhat.md) +- [Deploying a smart contract with Hardhat](../deploying-smart-contract/with-Hardhat), or +- [Deploying a smart contract with Foundry](../deploying-smart-contract/with-Foundry) ## Further resources