Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodejs 6 issues #15

Open
satazor opened this issue Jul 6, 2016 · 2 comments
Open

nodejs 6 issues #15

satazor opened this issue Jul 6, 2016 · 2 comments

Comments

@satazor
Copy link

satazor commented Jul 6, 2016

I've got a project with fixtures generated using nodejs 4 but the same fixtures do not work in nodejs 6 because they have a different signature. It seems that nodejs 6 changed some internals that are causing this issue.

@satazor
Copy link
Author

satazor commented Sep 26, 2016

After investigating, the issue is with JSON.stringify here: https://github.com/linkedin/sepia/blob/master/src/util.js#L339

Node 4 and Node 6 have discrepancies in the way they output unicodes.. one simply output as text and other as ASCII text (e.g.: \uxxxx).

One way to solve it is to base64 the JSON.stringify ouput before passing it to crypto.

@jimmyeisenhauer
Copy link

I just went from node 4.4.3 to 6.9.1 and didn't see any issues. Did they fix something in 6?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants