Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dustjs v3.0.0 #148

Open
mikaello opened this issue Jun 3, 2022 · 4 comments
Open

Support dustjs v3.0.0 #148

mikaello opened this issue Jun 3, 2022 · 4 comments

Comments

@mikaello
Copy link

mikaello commented Jun 3, 2022

In the peerDependencies section it is a requirement that the version of dustjs can't be above 2.8:

"dustjs-linkedin": "2.7 - 2.8"

Last year v3.0.0 was released (https://github.com/linkedin/dustjs/releases/tag/v3.0.0), it would be nice if dustjs-helpers could support that.

Trying to install dustjs v3 and dustjs-helpers will now result in:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: @mikaello/[email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/dustjs-linkedin
npm ERR!   dustjs-linkedin@"3.0.1" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer dustjs-linkedin@"2.7 - 2.8" from [email protected]
npm ERR! node_modules/dustjs-helpers
npm ERR!   dustjs-helpers@"1.7.4" from the root project

This is easily fixed by npm install --force or npm install --legacy-peer-deps, but it would be nice to avoid this.

@carlos-r-mendoza
Copy link

also running into this issue, it would be good to upgrade the peerDependencies of this project to avoid this issue.

@Syno0
Copy link

Syno0 commented Aug 23, 2022

Same here, would love to see dustjs and dustjs-helpers to be maintained at least for peerDependencies and security fix !

@t1a2l
Copy link

t1a2l commented Dec 21, 2022

@jimmyhchan Hello are you going to update this and dustjs ??

@mikaello
Copy link
Author

mikaello commented Feb 13, 2024

Since #149 is merged, the code is updated, but waiting for v1.8.0 to be published to NPM before closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants