Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cmd_presence #22

Open
alexalok opened this issue Aug 1, 2016 · 2 comments
Open

Add cmd_presence #22

alexalok opened this issue Aug 1, 2016 · 2 comments

Comments

@alexalok
Copy link
Contributor

alexalok commented Aug 1, 2016

Add a new terminal command to allow presence in a specified global room (with the possibility of addition and removing).

@Levak
Copy link
Owner

Levak commented Aug 1, 2016

Interesting idea.

I drop some design questions here:

  • Should it be able to join the clan room?
  • How would cmd_say behave after joining multiple rooms? For instance, one game room, 2 global rooms, and the clan room.
  • Wouldn't it be easier to automatically join global room as the game does? (warning, joining global rooms consumes way more bandwidth)

@alexalok
Copy link
Contributor Author

alexalok commented Aug 1, 2016

  1. AFAIK, there is still a flaw that allows to join all clan rooms, so I believe this it is not a good idea
  2. If there are 2+ joined rooms, require 3rd argument which is either room_id or all
  3. Personally, I would use this command only for joining global rooms, but in general autojoin would not only consume more bandwith but also spam debug output, so I think all "joins" should be explicitely required by user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants