This repository has been archived by the owner on Oct 16, 2024. It is now read-only.
Fix smartcard pyscard dependency versions and name #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version specification is invalid with recent setuptools and also the package name is `pyscard`. See pypa/setuptools#3801 fixes LedgerHQ#53
|
Would appreciate a merge or further comment on anything else needed before merge. |
|
Seconding this being merged and a new version pushed to pypi. |
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Aug 26, 2024
Summary: The latest btchip-python release contained a malformed dependency that used to be treated as a warning, but is now treated as an error by recent pip version. And even with the slightly older versions of pip currently used in release scripts we already get an error the Windows build, because there is an additional step (compared with the linux appimage build) that already treats this as an error. It seems like btchip-python is no longer maintained by Ledger, and the proposed fix in LedgerHQ/btchip-python#54 is not going to be merged and released. This diff changes the requirements file to install a version including that patch, downloaded from github's archive API Depends on D16667 Test Plan: Checked that the fix works. ``` python -m venv test-env source test-env/bin/activate pip install pip --upgrade pip --version pip install -r ~/dev/bitcoin-abc/electrum/contrib/deterministic-build/requirements-binaries.txt pip install -r ~/dev/bitcoin-abc/electrum/contrib/deterministic-build/requirements-hw.txt deactivate ``` Checked that the Windows release script works ``` contrib/build-wine/build.sh ``` Checked that the patch commit is based on the latest commit of https://github.com/LedgerHQ/btchip-python/commits/master/ (tag 0.1.32 + 2 commits that fix Fedora packaging). Checked the archive's sha256sum. Reviewers: #bitcoin_abc, roqqit Reviewed By: roqqit Differential Revision: https://reviews.bitcoinabc.org/D16669
Fabcien
pushed a commit
to Bitcoin-ABC/ElectrumABC
that referenced
this pull request
Aug 27, 2024
Summary: The latest btchip-python release contained a malformed dependency that used to be treated as a warning, but is now treated as an error by recent pip version. And even with the slightly older versions of pip currently used in release scripts we already get an error the Windows build, because there is an additional step (compared with the linux appimage build) that already treats this as an error. It seems like btchip-python is no longer maintained by Ledger, and the proposed fix in LedgerHQ/btchip-python#54 is not going to be merged and released. This diff changes the requirements file to install a version including that patch, downloaded from github's archive API Depends on D16667 Test Plan: Checked that the fix works. ``` python -m venv test-env source test-env/bin/activate pip install pip --upgrade pip --version pip install -r ~/dev/bitcoin-abc/electrum/contrib/deterministic-build/requirements-binaries.txt pip install -r ~/dev/bitcoin-abc/electrum/contrib/deterministic-build/requirements-hw.txt deactivate ``` Checked that the Windows release script works ``` contrib/build-wine/build.sh ``` Checked that the patch commit is based on the latest commit of https://github.com/LedgerHQ/btchip-python/commits/master/ (tag 0.1.32 + 2 commits that fix Fedora packaging). Checked the archive's sha256sum. Reviewers: #bitcoin_abc, roqqit Reviewed By: roqqit Differential Revision: https://reviews.bitcoinabc.org/D16669
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version specification is invalid with recent setuptools and also the package name is
pyscard.See pypa/setuptools#3801
fixes #53