New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad signature on some edge case #2

Open

xchapron-ledger opened this issue Oct 12, 2023 · 0 comments

xchapron-ledger commented Oct 12, 2023

In https://github.com/LedgerHQ/app-icx/blob/master/src/main.c#L521-L526
if rLength == 31, which can happen, then the signature will be invalid and transaction will be rejected by the blockchain.
A simpler implementation would be using cx_ecdsa_sign_rs_no_throw,a nd best would be changing all the crypto call to use directly helpers from https://github.com/LedgerHQ/ledger-secure-sdk/blob/master/lib_standard_app/crypto_helpers.h

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment