Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the client to only sign for a subset of key placeholders #177

Open
bigspider opened this issue Jun 26, 2023 · 0 comments
Open

Allow the client to only sign for a subset of key placeholders #177

bigspider opened this issue Jun 26, 2023 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@bigspider
Copy link
Collaborator

bigspider commented Jun 26, 2023

Currently, the app only uses the PSBT_IN_BIP32_DERIVATION/PSBT_IN_TAP_BIP32_DERIVATION to figure out the right change/address_index pair for each input. However, there is no way of explicitly instructing not to sign for some placeholders; this is a common need for miniscript-based wallets like Liana, where multiple spending paths might be controlled by the same device (with different derivations paths).

Rather than modifying the protocol, the simplest way might be to not sign with a placeholder if the corresponding PSBT_GLOBAL_XPUB is missing in the PSBT.

@bigspider bigspider added the enhancement New feature or request label Jun 26, 2023
@bigspider bigspider added this to the 2.2.0 milestone Jun 27, 2023
@bigspider bigspider modified the milestones: 2.2.0, 2.3.0 Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant