Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for 'poll-summary' when using 'thing' #59

Open
ZinkNotTheMetal opened this issue Oct 16, 2024 · 3 comments
Open

Support for 'poll-summary' when using 'thing' #59

ZinkNotTheMetal opened this issue Oct 16, 2024 · 3 comments

Comments

@ZinkNotTheMetal
Copy link

It looks like BGG added a new property in the XML API named 'poll-summary' with this the thing api no longer works properly and is throwing an error when binding to the BggThing object.

@darekkay
Copy link

I would argue that a new (unknown) property shouldn't break the existing API. I assume that LearningProcesss agrees, as they have created this request 2 years ago: pichillilorenzo/jackson-js#41

@ericpoulinnz
Copy link

That's a really frustrating underlying issue.

@LearningProcesss any chance this is a quick fix for this instance?

@darekkay
Copy link

I've posted the technical solution to ignoring unknown properties in the jackson-js repository. I have also fixed the issue in my fork, but only for this particular problem (BggThingDto object). If @LearningProcesss agrees with the proposal, I can implement it for all DTOs and raise a PR.

Until then, I am using a workaround with my own fork as an npm dependency:

{
  "boardgamegeekclient": "git+https://github.com/darekkay/boardgamegeekjsclient.git#2b62d8927fb183af5883dbf683e700d5b128107f"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants