Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strings are coming through encoded #54

Open
ericpoulinnz opened this issue Sep 25, 2023 · 3 comments
Open

Strings are coming through encoded #54

ericpoulinnz opened this issue Sep 25, 2023 · 3 comments
Assignees
@LearningProcesss
Labels
enhancement New feature or request

Comments

@ericpoulinnz
Copy link

Using the the latest version of the library (1.9.1), any string that contains certain characters (like apostrophes) are returned with encoding.

For example
Dean's house becomes Dean's house

This seems to affect all free-text fields: player names, locations, color, comments (both in collection results and play logs).

Can strings please come through as they were written on BGG? Going directly to the API has them come through correctly, e.g. https://api.geekdo.com/xmlapi2/plays?username=Hammerstrike
@ericpoulinnz
Copy link
Author

@LearningProcesss this feels like it should be a quick fix? Do you have an ETA? If not I will have to make some corrections on my end because I have just had my second user affected by this problem.

@LearningProcesss LearningProcesss self-assigned this Oct 7, 2023
@LearningProcesss LearningProcesss added the enhancement New feature or request label Oct 7, 2023
@ericpoulinnz
Copy link
Author

Hey @LearningProcesss, sorry to be annoying on this one. I saw there was a branch for this with the fix 11 days ago but no change since then, is it close to being merged in?

@ericpoulinnz
Copy link
Author

Hey @LearningProcesss , just checking everything is okay? Been a while since we've heard from you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LearningProcesss LearningProcesss

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

54-strings-are-coming-through-encoded LearningProcesss/boardgamegeekjsclient
2 participants
@ericpoulinnz @LearningProcesss