Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't apply this theme with remote_theme in _config.yml #34

Open
lynn9388 opened this issue Dec 1, 2017 · 6 comments
Open

Can't apply this theme with remote_theme in _config.yml #34

lynn9388 opened this issue Dec 1, 2017 · 6 comments

Comments

@lynn9388
Copy link
Contributor

lynn9388 commented Dec 1, 2017

GitHub Pages supports apply community-curated Jekyll themes in _config.yml. I tested it, but it doesn't work with this theme.

@LeNPaul
Copy link
Owner

LeNPaul commented Dec 2, 2017

Thanks for the heads up, I will investigate : )

@harveynick
Copy link

harveynick commented Nov 25, 2018

I think the issue is that this requires a .gemspec file to be added at the root. I tried this in my fork and it seems to work.

@lynn9388
Copy link
Contributor Author

I think the issue is that this requires a .gemspec file to be added at the root. I tried this in my fork and it seems to work.

Can you create a pull request of your solution?

@harveynick
Copy link

I can, but I used my name in the manifest since using Paul's seemed a little... presumptuous. I've also been tweaking a couple of other things to make it work more cleanly as a gem based theme, rather than an "in place one".

@LeNPaul
Copy link
Owner

LeNPaul commented Dec 25, 2018

I finally found some time to work on this. I will resolve this by the end of the day - thanks for all of your patience!

@LeNPaul
Copy link
Owner

LeNPaul commented Dec 30, 2018

Just a quick update: it's taking a bit longer than expected, and I will have to refactor the theme to make it more gem-friendly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants