Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧹 Example to programatically configure send and receive configs #857

Draft
wants to merge 29 commits into
base: main
Choose a base branch
from
Draft

🧹 Example to programatically configure send and receive configs #857

wants to merge 29 commits into from

Conversation

ravinagill15
Copy link
Contributor

@ravinagill15 ravinagill15 commented Aug 16, 2024 •
edited
Loading

In this PR

  • New package ua-devtools-evm-foundry with example solidity scripts to demonstrate how send and receive configs can be programatically set
  • Updated README with instructions on how to run forge scripts
  • Created test package tests/ua-devtools-evm-foundry-test

@socket-security Socket Security
Copy link

socket-security bot commented Aug 16, 2024 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@ravinagill15 ravinagill15 marked this pull request as draft August 16, 2024 23:43
@ravinagill15 ravinagill15 marked this pull request as ready for review August 19, 2024 17:16
@ravinagill15 ravinagill15 changed the title 🧹 Set config example scripts 🧹 Example to Programatically configure send and receive configs Aug 19, 2024
@ravinagill15 ravinagill15 changed the title 🧹 Example to Programatically configure send and receive configs 🧹 Example to programatically configure send and receive configs Aug 19, 2024
ryandgoulding
ryandgoulding requested changes Aug 19, 2024
View reviewed changes
forge-config-scripts/README.md Outdated Show resolved Hide resolved
forge-config-scripts/scripts/ReceiveConfig.s.sol Outdated Show resolved Hide resolved
forge-config-scripts/scripts/ReceiveConfig.s.sol Outdated Show resolved Hide resolved
forge-config-scripts/scripts/ReceiveConfig.s.sol Outdated Show resolved Hide resolved
forge-config-scripts/scripts/ReceiveConfig.s.sol Outdated Show resolved Hide resolved
forge-config-scripts/scripts/ReceiveConfig.s.sol Outdated Show resolved Hide resolved
forge-config-scripts/scripts/SendConfig.s.sol Outdated Show resolved Hide resolved
forge-config-scripts/scripts/SendConfig.s.sol Outdated Show resolved Hide resolved
ryandgoulding
ryandgoulding reviewed Aug 19, 2024
View reviewed changes
Copy link
Contributor

@ryandgoulding ryandgoulding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff! Had some nitty comments, but the approach looks right. Let me know if you have any questions!

@ravinagill15 ravinagill15 marked this pull request as draft August 20, 2024 00:05
ravinagill15
ravinagill15 commented Aug 20, 2024
View reviewed changes
packages/ua-devtools-evm-foundry/src/ReceiveConfig.sol
@@ -0,0 +1,35 @@
// SPDX-License-Identifier: MIT
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please double check licenses

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should replace in scripts with:

// SPDX-License-Identifier: UNLICENSED

@ravinagill15 ravinagill15 marked this pull request as ready for review August 20, 2024 20:03
@ravinagill15 ravinagill15 marked this pull request as draft August 20, 2024 20:04
@ravinagill15 ravinagill15 marked this pull request as ready for review August 20, 2024 20:18
@ravinagill15
Copy link
Contributor Author

Added do not merge label because we have not yet made a decision on whether we want to support foundry-only development. The reason is because this example cannot be used on non-evm chains, so if a client wants to move to solana, for example, they would need to learn a whole new set of tools.

St0rmBr3w
St0rmBr3w requested changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@St0rmBr3w St0rmBr3w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing that would be great to be added here is E2E for calling:

setSendLibrary
setReceiveLibrary
setReceiveLibraryTimeout

forge-config-scripts/scripts/ReceiveConfig.s.sol Outdated Show resolved Hide resolved
packages/ua-devtools-evm-foundry/src/ReceiveConfig.sol
@@ -0,0 +1,35 @@
// SPDX-License-Identifier: MIT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should replace in scripts with:

// SPDX-License-Identifier: UNLICENSED

@ravinagill15
init for testing forge set config scripts
3ab801d
@ravinagill15
wrote receiveConfig test, now passing receiveConfig as param
5d747e6
@ravinagill15
test for receive config, more tests incoming
f1d518a
@ravinagill15
working on tests
bd453ae
@ravinagill15
cleanup
49024ae
@ravinagill15
added send config tests
c6d4657
@ravinagill15
cleaning up sendconfig script
5fd6630
@ravinagill15
fixed receive config library tests
af233ae
@ravinagill15
fixed tests, cleaned up imports
fd10760
@ravinagill15
missing semicolon
8c52178
@ravinagill15
updating readme
4f5f104
@ravinagill15
fixed tests
138a1b8
@ravinagill15
ensured scripts work from command line in ua-devtools-evm-foundry and…
4fccac5 
… updated readme
@ravinagill15
updated pnpm lock
827ed0f
@ravinagill15
updated readme to include pnpm i
97a4bd3
@ravinagill15
cleanup
a735c7e
@ravinagill15
updated toolbox-foundry with ua-devtools-evm-foundry dependency and e…
d4d7dab 
…nsured running make lib populates lib, also added license
@ravinagill15
removed unneeded forge-config-scripts directory
7ce8dc8
@ravinagill15
licensing
5869c36
@ravinagill15
reverting toolbox-foundry changes to see if circular dependency is fixed
e816b4e
@ravinagill15
reverted pnpmlock
b36967f
@ravinagill15
using nums to convert to addr instead of placing load on fuzz testing
5739d70
@ravinagill15 ravinagill15 marked this pull request as draft September 12, 2024 15:35
@socket-security Socket Security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@layerzerolabs/[email protected] Transitive: filesystem, network +27 15.8 MB layerzero-bot
npm/@layerzerolabs/[email protected] None 0 5.37 MB layerzero-bot
npm/@layerzerolabs/[email protected] None +1 913 kB layerzero-bot

View full report↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@St0rmBr3w St0rmBr3w St0rmBr3w requested changes

@janjakubnanista janjakubnanista Awaiting requested review from janjakubnanista

@ryandgoulding ryandgoulding Awaiting requested review from ryandgoulding

@TRileySchwarz TRileySchwarz Awaiting requested review from TRileySchwarz

@sirarthurmoney sirarthurmoney Awaiting requested review from sirarthurmoney

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ravinagill15 @ryandgoulding @St0rmBr3w