Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APP folder (UI) is too old. Server-UI decoupling #60

Open
jorgerobles opened this issue May 22, 2018 · 3 comments
Open

APP folder (UI) is too old. Server-UI decoupling #60

jorgerobles opened this issue May 22, 2018 · 3 comments

Comments

@jorgerobles
Copy link
Contributor

Hi,

I've run on a somewhat serious issue due the folder App being far away current version (8 months!)
I've been refactoring the binaries build chain, decoupling lw.comm-server from electron (at least for WIN and OSX, cannot get LNX working on multiple travis file)
Then the version bundled was way back because nstatic was serving the inner lw.comm-server app instead the new UI (I've patched the APP using travis and overriding the folder with the newer)

I would suggest to not to include APP on the comms, but make a build script to download and compile first time if folder does not exist (for users not using the bundled version)
For example using travis to automatically build the app folder and being able to download from Github Laserweb4 Releases (not binaries, just LW4 containing the app.zip)

Also, I would like to have the option to not to run nstatic or be able to change the path where is served, the builder can choose another app folder. That could lead to having an UI updater without changing nor the builder nor the server.

@cprezzi, @tbfleming

@cprezzi
Copy link
Member

cprezzi commented May 23, 2018

My idea was to pack a responsive mini frontend into the static app folder. This could be usefull to controll the machine with a tablett or mobile and should not interfer with the installed LW Application.

@jorgerobles
Copy link
Contributor Author

jorgerobles commented May 23, 2018 via email

@jorgerobles
Copy link
Contributor Author

jorgerobles commented May 24, 2018

Tested.. works beautifully https://github.com/Ivshti/asar-server/blob/master/init.js#L5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants