Skip to content

Commit 052dd08

Browse files
Fix type hints and finish tests
1 parent df29086 commit 052dd08

File tree

2 files changed

+30
-8
lines changed

2 files changed

+30
-8
lines changed

src/python/demoparser2.pyi

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ class DemoParser:
2727
def parse_ticks(
2828
self,
2929
wanted_props: Sequence[str],
30-
player: Optional[Sequence[int]] = None,
30+
players: Optional[Sequence[int]] = None,
3131
ticks: Optional[Sequence[int]] = None,
3232
) -> pd.DataFrame:
3333
"""Parse the specified props.

src/python/tests/signature_tests.py

+29-7
Original file line numberDiff line numberDiff line change
@@ -123,13 +123,35 @@ def test_parse_events_signature(self):
123123
with self.assertRaises(TypeError):
124124
parser.parse_events(5)
125125

126-
# def parse_voice(self) -> Dict[str, bytes]: ...
127-
# def parse_ticks(
128-
# self,
129-
# wanted_props: Sequence[str],
130-
# player: Optional[Sequence[int]] = None,
131-
# ticks: Optional[Sequence[int]] = None,
132-
# ) -> pd.DataFrame:
126+
def test_parse_voice_signature(self):
127+
parser = DemoParser("tests/data/test.dem")
128+
voice = parser.parse_voice()
129+
self.assertIsInstance(voice, dict)
130+
for key, value in voice.items():
131+
self.assertIsInstance(key, str)
132+
self.assertIsInstance(value, bytes)
133+
134+
def test_parse_ticks_signature(self):
135+
parser = DemoParser("tests/data/test.dem")
136+
137+
ticks = parser.parse_ticks(["X", "Y"])
138+
self.assertIsInstance(ticks, pd.DataFrame)
139+
140+
parser.parse_ticks(["X", "Y"], players=[1, 2, 3], ticks=[1, 2, 3])
141+
parser.parse_ticks(["X", "Y"], players=None, ticks=None)
142+
parser.parse_ticks(["X", "Y"], players=[], ticks=[])
143+
144+
with self.assertRaises(TypeError):
145+
parser.parse_ticks(["X", "Y"], players=5, ticks=None)
146+
147+
with self.assertRaises(TypeError):
148+
parser.parse_ticks(["X", "Y"], players=None, ticks=5)
149+
150+
with self.assertRaises(TypeError):
151+
parser.parse_ticks(["X", "Y"], players="Test")
152+
153+
with self.assertRaises(TypeError):
154+
parser.parse_ticks(5)
133155

134156

135157
if __name__ == "__main__":

0 commit comments

Comments
 (0)