Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include same warning comments from TFD in bindings class #951

Open
ThatGravyBoat opened this issue Dec 7, 2023 · 0 comments
Open

Include same warning comments from TFD in bindings class #951

ThatGravyBoat opened this issue Dec 7, 2023 · 0 comments

Comments

@ThatGravyBoat
Copy link

ThatGravyBoat commented Dec 7, 2023

Description

TinyFileDialog added a warning at the top of their files saying to not use user input (https://github.com/LWJGL/lwjgl3/blob/master/modules/lwjgl/tinyfd/src/main/c/tinyfiledialogs.c#L50). This is because it could and has been a pathway for vulnerabilities as previous versions of TFD had command injection vulnerabilities (CVE-2020-36767 and CVE-2023-47104).

It would be good to include this warning into the bindings aswell and possibly change the wording as to change it from "Do not use user inputs" to something along the lines of "Do not use untrusted inputs" as its more suitable.

A similar warning was also added to other bindings for TFD such as rust here jdm/tinyfiledialogs-rs#40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant