Slecting and deleting multiple Tidal playlists does not work

[Tontze]

Describe the bug
After i removed Tidal account and plugin, i tried to delete all Tidal playlists. Selecting many lists and deleting only deletes last selected playlist.

To Reproduce
Steps to reproduce the behavior:

1. Go to ' My Music' then 'Playlists'
2. Select first one using three dots on the right side of the playlist, then you can select many using icon in front of the playlist
3. select thrash cab icon (delete all selected items)
4. Only last one gets deleted.

Expected behavior
All selected playlists should be deleted

System Information (please complete the following information):

• Container in Truenas system
• Web skin used: Material
• Browser Firefox
• LMS 9.0.4
• Player(s) involved: Picoreplayer 8.2.0

[michaelherger]

I guess that's a Material issue. But then you can just run a wipe & rescan and those lists will be gone.

[Tontze]

I guess that's a Material issue. But then you can just run a wipe & rescan and those lists will be gone.

Tried to find same feature from other skins but couldnt find. Ill try that wipe, if i find it :D

[michaelherger]

Or you head over to the Material Skin repository if in doubt? https://github.com/CDrummond/lms-material/issues

[CDrummond]

When deleting a list of playlists Material simply deletes each one-by-one (by using ["playlists", "delete", "playlist_id:XXX"]). However, if LMS returns an error response when deleting one playlist, then the process is halted.

I've just tried to delete 3 local playlists like this and it worked. Seeing as the same command would be used for remote playlists, not sure what the issue could be. I'd look for errors logged by LMS (not saying this is an LMS issue, just that errors should be logged there...)

[michaelherger]

@Tontze could you please provide us with a copy of your server.log.zip (Settings/Information) and upload it to https://www.dropbox.com/request/T3RctyzGgNg0oFDubq6a?

[Tontze]

This is what is logged when i try to delete two tidal playlists:

[25-12-08 17:48:10.7892] Slim::Utils::Misc::pathFromFileURL (233) Error: Path isn't a file URL: tidal://playlist:e6b1d484-789b-4f5a-8b78-bbfc4ec2700d
[25-12-08 17:48:10.7898] Slim::Utils::Misc::pathFromFileURL (233) Backtrace:

   frame 0: Slim::Utils::Log::logBacktrace (/lms/Slim/Utils/Misc.pm line 233)
   frame 1: Slim::Utils::Misc::pathFromFileURL (/lms/Slim/Schema.pm line 2543)
   frame 2: Slim::Schema::_hasChanged (/lms/Slim/Schema.pm line 2500)
   frame 3: Slim::Schema::_checkValidity (/lms/Slim/Schema.pm line 848)
   frame 4: Slim::Schema::objectForUrl (/lms/Slim/Schema.pm line 698)
   frame 5: Slim::Schema::contentType (/lms/Slim/Music/Info.pm line 1220)
   frame 6: Slim::Music::Info::_isContentTypeHelper (/lms/Slim/Music/Info.pm line 1315)
   frame 7: Slim::Music::Info::isPlaylist (/lms/Slim/Schema/Track.pm line 375)
   frame 8: Slim::Schema::Track::isPlaylist (/lms/Slim/Control/Commands.pm line 2321)
   frame 9: Slim::Control::Commands::playlistsDeleteCommand (/lms/Slim/Control/Request.pm line 1879)
   frame 10: (eval) (/lms/Slim/Control/Request.pm line 1879)
   frame 11: Slim::Control::Request::execute (/lms/Slim/Web/JSONRPC.pm line 476)
   frame 12: Slim::Web::JSONRPC::requestMethod (/lms/Slim/Web/JSONRPC.pm line 275)
   frame 13: (eval) (/lms/Slim/Web/JSONRPC.pm line 275)
   frame 14: Slim::Web::JSONRPC::handleURI (/lms/Slim/Web/HTTP.pm line 485)
   frame 15: Slim::Web::HTTP::processHTTP (/lms/Slim/Networking/IO/Select.pm line 123)
   frame 16: (eval) (/lms/Slim/Networking/IO/Select.pm line 119)
   frame 17: Slim::Networking::IO::Select::__ANON__ (/lms/Slim/Networking/IO/Select.pm line 168)
   frame 18: (eval) (/lms/Slim/Networking/IO/Select.pm line 168)
   frame 19: Slim::Networking::IO::Select::loop (/lms/slimserver.pl line 727)
   frame 20: main::idle (/lms/slimserver.pl line 676)
   frame 21: main::main (/lms/slimserver.pl line 1212)

[25-12-08 17:48:10.9354] Slim::Web::JSONRPC::requestMethod (481) Request failed with error: Bad params!
[25-12-08 17:48:10.9413] Slim::Web::JSONRPC::requestMethod (481) Request failed with error: Bad params!

[michaelherger]

@Tontze can you confirm that the playlist mentioned in that message actually is the one that got deleted?

@CDrummond do you delete from the bottom up, or is there no defined order in which you delete items? What I'm seeing is that the playlist deleted, despite the noise in the log file. I'm wondering why only one would be deleted.

@Tontze can you check the browser's dev tools to see whether all deletion requests are being sent, and what they receive back?

[CDrummond]

@michaelherger No particular order. I could change to delete bottom up, if that'd help? I assumed as playlist_id was used it would not matter.

[michaelherger]

Yeah, I was only wondering because @Tontze mentioned only the last one got deleted. Might be a coincidence.

[CDrummond]

@michaelherger I've just committed a change to Material to remove bottom up.

[Tontze]

@Tontze can you confirm that the playlist mentioned in that message actually is the one that got deleted?

Yes, only the last one of the selected playlists gets deleted.

@CDrummond do you delete from the bottom up, or is there no defined order in which you delete items? What I'm seeing is that the playlist deleted, despite the noise in the log file. I'm wondering why only one would be deleted.

@Tontze can you check the browser's dev tools to see whether all deletion requests are being sent, and what they receive back?

Need some advice with the dev tools, what should i look for and how ? Im using firefox.

[michaelherger]

see eg. https://firefox-source-docs.mozilla.org/devtools-user/

There should be a network tab where you're seeing what is going on between the browser and the server. Open that tab before you start deletion. Then check how many requests (most likely jsonrp.js) are being sent. Clicking on those entries you'd be able to see what command was sent.

[Tontze]

Ok, this is what came up :

EDIT: Oh yeah, ill look deeper in to them later ..

[Tontze]

There was two jsonrp.c when i tried to delete two playlists, here is requests and responce tabs:

second one:

[michaelherger]

Hmm... there should be more. Queries with 0 ... 9999 (two numbers as first parameters) are usually fetching a list of things. In your case it's fetching the list of playlists. The second queries the status of the player.

What you are looking for is ["playlists","delete","playlist_id:123456"].