Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why combine vertical photos on max interest factor? #1

Open
DylanRussell opened this issue Sep 15, 2019 · 2 comments
Open

why combine vertical photos on max interest factor? #1

DylanRussell opened this issue Sep 15, 2019 · 2 comments

Comments

@DylanRussell
Copy link

wouldn't it be better to combine vertical images with the min interest factor between them, given no points are awarded here?

a slide with vertical images next to a slide with vertical images could have more points this way

@jveitchmichaelis
Copy link
Contributor

jveitchmichaelis commented Sep 16, 2019

Not sure. We tried some approaches for pairing vertical slides, but it didn't work so well.

Two adjacent slides with vertical images can exist in this solution. If you have a horizontal slide and the best photo to pair it with is vertical, then we do that, then we check which other vertical image which will improve the score (or at least not decrease it). Then the next slide could also be two verticals again.

@DylanRussell
Copy link
Author

ok, understood. i just think combining vertical slides in that way possibly removes those slides' best partner. maybe combining before partnering would also help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants