Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framerate adjustment for Encoders #32

Open
JessyClain opened this issue Mar 21, 2024 · 0 comments
Open

Framerate adjustment for Encoders #32

JessyClain opened this issue Mar 21, 2024 · 0 comments

Comments

@JessyClain
Copy link

Discussion Thread

Vhonowslend/StreamFX-Public#845

Provide a summary of the Improvement

It should be possible to split Stream framerate from Recording framerate, so that users do not have to sacrifice either stream or recording quality. Ideally this should be a drop-in class or handled on the encoder factory itself, so that it can easily be reused by future encoders.

Completion Requirements

  • Easily integratable in future encoder implementations. A junior C/C++ developer should be able to integrate this change within 1 hour of starting.
    • This either means a separate class or direct integration into the common encoder factory.
  • Code should have enough comments to be understood, but not too many.
    • int a = 1; // Assigns 1 to a is pointless.
    • a *= std::max(b/c, log(d)) / log2(e); should definitely have a comment.
    • Multiple comments may be grouped into one block preceding the difficult section.
  • Code is licensed under GPLv2 or later.
  • Zero-Copy and multi-GPU functionality must stay in tact.
  • Framerate adjustment should be integer fraction of the OBS framerate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant