Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few renaming suggestions #48

Open
madsmtm opened this issue Sep 21, 2022 · 0 comments
Open

A few renaming suggestions #48

madsmtm opened this issue Sep 21, 2022 · 0 comments

Comments

@madsmtm
Copy link
Contributor

madsmtm commented Sep 21, 2022

Hey, thanks a lot for making this library, it's great!

When you get around to releasing a new version, may I suggest the following?

  • A lot of methods use the get_ prefix, which is generally discouraged in Rust (source); so instead of e.g. get_name(), just use name().
  • It was confusing to me at first that "entity" means "cursor", so I'd either rename the Entity struct to Cursor, to match the original bindings, or at least document it.

Of course, if there's reasons for not doing these, then by all means do so, just wanted to note the few gripes I had.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant