You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey, thanks a lot for making this library, it's great!
When you get around to releasing a new version, may I suggest the following?
A lot of methods use the get_ prefix, which is generally discouraged in Rust (source); so instead of e.g. get_name(), just use name().
It was confusing to me at first that "entity" means "cursor", so I'd either rename the Entity struct to Cursor, to match the original bindings, or at least document it.
Of course, if there's reasons for not doing these, then by all means do so, just wanted to note the few gripes I had.
The text was updated successfully, but these errors were encountered:
Hey, thanks a lot for making this library, it's great!
When you get around to releasing a new version, may I suggest the following?
get_
prefix, which is generally discouraged in Rust (source); so instead of e.g.get_name()
, just usename()
.Entity
struct toCursor
, to match the original bindings, or at least document it.Of course, if there's reasons for not doing these, then by all means do so, just wanted to note the few gripes I had.
The text was updated successfully, but these errors were encountered: