Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rerendering #10

Open
hampsterx opened this issue Jul 21, 2015 · 4 comments
Open

rerendering #10

hampsterx opened this issue Jul 21, 2015 · 4 comments

Comments

@hampsterx
Copy link

seems not to rerender if data is changed :(

@KyleAMathews
Copy link
Owner

No it doesn't atm... Happy to take a pr. I'm not using or maintaining this
module atm so if you're interested in maintaining it, just say so.
On Tue, Jul 21, 2015 at 2:44 PM TiM [email protected] wrote:

seems not to rerender if data is changed :(


Reply to this email directly or view it on GitHub
#10.

@KyleAMathews
Copy link
Owner

A hackish way to force a re-render is to set a key based on some part of your data. When the key changes, React drops the old component and rerenders things. Not very high performance obviously. Someone who knows D3 a lot better than me is very welcome to rework this module so it adjusts to new props. Or switch to Victory.js once tooltips are added FormidableLabs/victory#83

@jikkujose
Copy link

Pretty new to React; wish to take a shot at this. Just couldn't have it rerender, where can I dig?

@KyleAMathews
Copy link
Owner

@jikkujose this component is pretty small. Look through it's source file and try to understand it https://github.com/KyleAMathews/react-micro-bar-chart/blob/master/src/index.cjsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants