fix(response-ratelimiting): fix missing usage headers for upstream #13696
+111
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
plugins/response-ratelimiting
cherry-pick kong-ee
1 task
|
@t-yuki Thanks for your contribution! Would you mind adding a regression test on this issue? I think we have missed this test for a long time. And also a changelog entry. |
ADD-SP
added
the
author/community
|
Since this is a new issue introduced in 3.8 and should be a small fix, I added this to the 3.9 milestone. Internal ticket: KAG-5447 |
t-yuki
force-pushed
the
fix-response-ratelimiting-usage-headers
branch
from
be001e0
to
d785d18
Compare
t-yuki
force-pushed
the
fix-response-ratelimiting-usage-headers
branch
from
d785d18
to
7b344bb
Compare
|
@t-yuki Could you fix failure tests? |
OK, I'll try to continue within a week. |
t-yuki
force-pushed
the
fix-response-ratelimiting-usage-headers
branch
from
7b344bb
to
9d4e821
Compare
gszr
reviewed
Nov 18, 2024
changelog/unreleased/kong/fix-response-ratelimiting-upstream-headers.yml
Outdated
Show resolved
Hide resolved
…eaders.yml Co-authored-by: Guilherme Salazar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
response-ratelimitingplugin should send usage headers to upstream server.But in Kong 3.8, there are no usage headers such as
X-RateLimit-Remaining-Videos: 10for upstream requests.In this change, it coming back usage headers for upstream.
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix #13682