-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add/kdf/active swaps v2 #374
Conversation
Preview for merge commit: 076046e, available on cloudflare at: https://1f7503fb.komodo-docs.pages.dev/en/docs/ |
The `active_swaps` method returns all the swaps that are currently running on the Komodo DeFi Framework API node. | ||
|
||
<Note> | ||
This method has been deprecated in favor of (active\_swaps v2)\[/komodo-defi-framework/api/v20/active\_swaps]. The legacy version does not include v2 (Trading Protocol Upgrade) swap statuses in responses (it only returns uuids for these). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your linking brackets are being escaped here. So on the front-end the link isn't working.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest of the updates seem to be all in order.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, found the cause of this being ()[]
wehere it should be []()
. There were a couple other instance of this in the repo which have now also been fixed in this PR.
Preview for merge commit: e43428a, available on cloudflare at: https://2cc78fc7.komodo-docs.pages.dev/en/docs/ |
Preview for merge commit: f17c4ae, available on cloudflare at: https://6cc7f59c.komodo-docs.pages.dev/en/docs/ |
Preview for merge commit: 4170536, available on cloudflare at: https://01c73e18.komodo-docs.pages.dev/en/docs/ |
Preview for merge commit: 13f7bba, available on cloudflare at: https://0043735a.komodo-docs.pages.dev/en/docs/ |
Closes #281