Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make ibc_source_channel required for IBC transfers #2271

Closed
onur-ozkan opened this issue Nov 13, 2024 · 1 comment
Closed

make ibc_source_channel required for IBC transfers #2271

onur-ozkan opened this issue Nov 13, 2024 · 1 comment
Labels
improvement: protocol priority: urgent Critical tasks requiring immediate action.

Comments

@onur-ozkan
Copy link
Member

For IBC transfers, if ibc_source_channel is not provided, we currently try to detect it automatically from https://github.com/cosmos/chain-registry. But this approach is risky and unreliable as the channels are often outdated, which could lead to a loss of funds (the fee part only). To improve safety and reliability we should remove this auto-detection logic and require users to specify ibc_source_channel manually and make them responsible for its correctness. This approach will allow users to rely on more reliable IBC channels by simply picking the most popular ones from sources like https://ibc.iobscan.io/channels.

@onur-ozkan
Copy link
Member Author

These

"ibc_chains" => handle_mmrpc(ctx, request, ibc_chains).await,
"ibc_transfer_channels" => handle_mmrpc(ctx, request, ibc_transfer_channels).await,

2 RPCs should be removed as well.

@onur-ozkan onur-ozkan changed the title make ibc_source_channel non-optional for IBC transfers make ibc_source_channel required for IBC transfers Nov 13, 2024
@onur-ozkan onur-ozkan added priority: urgent Critical tasks requiring immediate action. improvement: protocol and removed P1 labels Dec 12, 2024
@onur-ozkan onur-ozkan closed this as not planned Won't fix, can't repro, duplicate, stale Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement: protocol priority: urgent Critical tasks requiring immediate action.
Projects
None yet
Development

No branches or pull requests

1 participant