Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add line comments to specifically ignore a issue on a line #85

Open
CreepPork opened this issue Oct 14, 2018 · 4 comments
Open

Add line comments to specifically ignore a issue on a line #85

CreepPork opened this issue Oct 14, 2018 · 4 comments

Comments

@CreepPork
Copy link

Similarly like ReSharper does it. Could be useful to mitigate some issues that are only picked up by armake and don't affect actual application performance.

For example:

// ReSharper disable once ReplaceWithStringIsNullOrEmpty
@dedmen
Copy link
Contributor

dedmen commented Nov 20, 2018

what kind of issues do you mean?
Armake is not a linter or syntax checker. If it stumbles upon an error, it's an error.

@CreepPork
Copy link
Author

@dedmen
See #84.

@dedmen
Copy link
Contributor

dedmen commented Nov 20, 2018

That was a bug in the armake parser.
Bugs should be fixed rather than marked with comments to ignore the resulting warnings.

Only real thing that you could mark to ignore is the unquoted strings stuff.
But that is really a error in config and should be fixed accordingly.

@CreepPork
Copy link
Author

It’s up for debate. I’d agree with issues being fixed not ignored but sometimes you could run into a wall and this could be a temp fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants