Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 3.2.6 breaks trame-vtk local rendering #34

Open
bourdaisj opened this issue Jan 7, 2025 · 6 comments
Open

release 3.2.6 breaks trame-vtk local rendering #34

bourdaisj opened this issue Jan 7, 2025 · 6 comments

Comments

@bourdaisj
Copy link
Contributor

it seems that this line make trame-vtk app with local rendering crash:

raise ValueError(error)

@bourdaisj
Copy link
Contributor Author

stacktrace:

Traceback (most recent call last):
  File "./trame-app/app.py", line 120, in <module>
    html_view = vtk_widgets.VtkLocalView(
                ^^^^^^^^^^^^^^^^^^^^^^^^^
  File ".venv/lib/python3.11/site-packages/trame_vtk/widgets/vtk/common.py", line 911, in __init__
    self.update()
  File "/.venv/lib/python3.11/site-packages/trame_vtk/widgets/vtk/common.py", line 937, in update
    full_state = self._helper.scene(
                 ^^^^^^^^^^^^^^^^^^^
  File "/.venv/lib/python3.11/site-packages/trame_vtk/modules/vtk/__init__.py", line 78, in scene
    scene_state = self._trame_server.protocol_call(
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/.venv/lib/python3.11/site-packages/trame_server/core.py", line 519, in protocol_call
    raise ValueError(error)
ValueError: Protocol does not exist yet

@jourdain
Copy link
Collaborator

jourdain commented Jan 7, 2025

Should we update trame-vtk to do a try/except ValueError instead?

@jourdain
Copy link
Collaborator

jourdain commented Jan 7, 2025

It might be good to know if the call was successful or not?

@bourdaisj
Copy link
Contributor Author

I agree try/except is generally better. No strong opinion on this though. Should try except and simply write a log entry if a value error raises?

@jourdain
Copy link
Collaborator

jourdain commented Jan 9, 2025

trame-vtk>=2.8.14 should be fine now

@user27182
Copy link

trame-vtk>=2.8.14 should be fine now

This resolved a similar issue for us in pyvista/pyvista#7067, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants