Unit Test Failure - CryptorRSATests#testSpecificPEM

[LowAmmo]

Getting a Unit Test Failure when running on Xcode 15 and Xcode 16, targeting the iPhone Simulator or the Mac.

BlueRSA/Tests/CryptorRSATests/CryptorRSATests.swift

Line 793 in b70be8c

func testSpecificPEM() {

The specific error that is thrown from the CryptorRSA.createPublicKey() method is:

 Error code: -9999(0x-270F), Couldn't create key reference from key data

The actual failing API is the call to SecKeyCreateWithData

BlueRSA/Sources/CryptorRSA/CryptorRSAUtilities.swift

Line 145 in b70be8c

guard let key = SecKeyCreateWithData(keyData as CFData, keyDict as CFDictionary, nil) else {

The key line seems to be where we are stripping the first 27 bytes due to the 26th byte being 0x30 -

BlueRSA/Sources/CryptorRSA/CryptorRSAUtilities.swift

Line 225 in b70be8c

if keyData[26] == 0x30 {

(not advancing 26 bytes there allows the test to pass, however then a different test fails - test_private_initWithPKCS8

BlueRSA/Tests/CryptorRSATests/CryptorRSATests.swift

Line 299 in b70be8c

func test_private_initWithPKCS8() throws {

(because it fails to create the privateKey - returns nil)

Proposed Solution

It appears the issue (based on code comments) is that it is stripping the first 26 bytes on any key type (public or private), but should ONLY strip the bytes for a private key.

So, making a change to only strip if the type is private.

Will get a PR out - assuming that is the correct fix.

[LowAmmo]

Pull Request to fix: #86