-
-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qwik support #663
Comments
Good day @thejackshelton I've already played around with qwik and tried to make a Unfortunately there were some roadblocks, mainly:
The first one is unfortunately a deal breaker and leads to unexpected behavior. I'm not sure whether you have a bit more insight into this topic, possibly having a workaround or idea of how to improve qwik in that area. You can find my attempt in porting the library to qwik in the feat-overlayscrollbars-qwik branch. Please note that this is unfinished sample code where I just played with how qwik works. That being said I would gladly collaborate with qwik-ui by creating a port / integration of the library :) |
Hey @KingSora! I think this month I'll be able to tackle it, or at the very least spend a bit of time on it. Hard to balance with Qwik and the other projects I work on and maintain, but I think it's important that this project has a Qwik integration. As for a workaround, you can use the Qwik UI popover while Qwik is still in v1, or see the workaround we did under the hood to achieve it which should work similar to portals and the ability to move other content around the DOM. In Qwik V2, which an alpha coming up very soon soon, there is the concept of vNodes or "markers" that communicate with the JSX in a very lazy way. This would solve the deal breaker blocker. Could you guide me on where I could start? Or is there an effort that was started on this somewhere already? |
Hey @thejackshelton and sorry for the late answer.. I'm kind of busy at the moment. Thats great news regarding Qwik |
@thejackshelton I had some spare this weeking and took a look at If you find time please give me feedback.. I've tried to follow any best practices I could find but since I'm fairly new to qwik I would love to hear what you think. The things I'm unsure about are:
The example code of the app can be found here. The most interesting bits should be the OverlayScrollbarsComponent as well as the useOverlayScrollbars hook. You can checkout the repo or directly the |
Hey @KingSora! I'll take a look this week for sure. Appreciate the awesome work on this 💪 |
@thejackshelton looking forward to it :) |
Is your feature request related to a problem? Please describe.
In Qwik UI we currently do a decent bit of hackery to get scroll working correctly. In other headless libraries we see a "scroll area" component, although this tends to be very complex, and often unmaintained and hacky scroll behavior.
Overlay Scrollbars seems like a good fit to use for Qwik UI, if there's a way we can allow people to easily integrate the overlay scrollbars library into their qwik ui components.
Describe the solution you'd like
I'd like to be able to integrate overlay scrollbars with Qwik UI in a way that does not execute code until the scroll interaction. Making the components we use for select, combobox, etc. to play nicely with their own custom scrollbars.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
We've considered creating our own scroll area component, and alternative scrollbar libraries
Additional context
I can dedicate some time in the future to trying to figure this out 😅 . Thought I'd bring the idea ahead of time so that the development process would be more straightforward.
The text was updated successfully, but these errors were encountered: