Skip to content

Commit f938449

Browse files
Remove hubble.js (#2383)
## Summary: Perseus no longer uses hubble.js in our repo. As such I'm removing that package and remaining build configurations. Issue: ---- ## Test plan: Run `pnpm install`, `pnpm build`, `pnpm lint`, and `pnpm test`. All things should pass and nothing should change in perseus implementation. Author: catandthemachines Reviewers: handeyeco, catandthemachines, jeremywiebe, benchristel Required Reviewers: Approved By: handeyeco, jeremywiebe Checks: ✅ 8 checks were successful Pull Request URL: #2383
1 parent 8d63aed commit f938449

File tree

12 files changed

+8
-293
lines changed

12 files changed

+8
-293
lines changed

.changeset/happy-radios-help.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
"perseus-build-settings": patch
3+
"@khanacademy/perseus": patch
4+
"@khanacademy/perseus-editor": patch
5+
---
6+
7+
Removing dependency on hubble.js

config/build/rollup.config.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,6 @@ const createConfig = (
142142
// then they are marked as external and not bundled (by the
143143
// autoExternal() plugin). For now, this works!
144144
entries: {
145-
hubble: path.join(rootDir, "vendor", "hubble"),
146145
jsdiff: path.join(rootDir, "vendor", "jsdiff"),
147146
raphael: path.join(rootDir, "vendor", "raphael"),
148147
},

knip.config.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ const config: KnipConfig = {
2222
// symlinked type defs for third-party libs
2323
"**/aphrodite.d.ts",
2424
"**/assets.d.ts",
25-
"**/hubble.d.ts",
2625
"**/jsdiff.d.ts",
2726
"**/raphael.d.ts",
2827
"**/utility.d.ts",

packages/perseus-editor/tsconfig-build.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
"rootDir": "src",
66
"paths": {
77
"jsdiff": ["../../vendor/jsdiff/jsdiff.js"],
8-
"hubble": ["../../vendor/hubble/hubble.js"],
98
// NOTE(kevinb): We have to repeat this here because TS doesn't do
109
// intelligent merge of tsconfig.json files when using `extends`.
1110
"@khanacademy/*": [

packages/perseus/tsconfig-build.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
"outDir": "./dist",
55
"rootDir": "src",
66
"paths": {
7-
"hubble": ["../../vendor/hubble/hubble.js"],
87
"raphael": ["../../vendor/raphael/raphael.js"],
98
// NOTE(kevinb): We have to repeat this here because TS doesn't do
109
// intelligent merge of tsconfig.json files when using `extends`.

pnpm-lock.yaml

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tsconfig.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
"compilerOptions": {
1515
"noEmit": true,
1616
"paths": {
17-
"hubble": ["./vendor/hubble/hubble.js"],
1817
"jsdiff": ["./vendor/jsdiff/jsdiff.js"],
1918
"raphael": ["./vendor/raphael/raphael.js"],
2019
"@khanacademy/kas": ["./packages/kas/src"],

types/hubble.d.ts

Lines changed: 0 additions & 1 deletion
This file was deleted.

vendor/hubble/README.md

Lines changed: 0 additions & 20 deletions
This file was deleted.

vendor/hubble/hubble.js

Lines changed: 0 additions & 257 deletions
This file was deleted.

0 commit comments

Comments
 (0)