Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to only use this module when the browser requires it? #44

Open
DanielWhiteCerner opened this issue May 22, 2018 · 2 comments

Comments

@DanielWhiteCerner
Copy link

This script self-executes immediately, meaning it doesn't check if it's needed or not.

It would be useful if we could choose when to initialize the event listeners, so we could decide if it's necessary or not.

For example, I only need it for IE11/Windows 10. Anything else seems to work fine - so it'd just be checking SVGs pointlessly.

Would that be too complicated to implement?

@foliovision
Copy link

We are noticing that when using svgxuse Flowplayer doesn't play on iOS when using the splash setup.

You can check it on this URL: http://foliovision.com/html/fp-svgxuse.html We load the https://cdnjs.cloudflare.com/ajax/libs/svgxuse/1.2.6/svgxuse.js script on that page and you can't click the player to play anymore.

Should the svgxuse script be running at all on iOS?

Thanks,
Martin

@markinfurkin
Copy link

markinfurkin commented Jul 28, 2018

@foliovision it also occurs to plyr.io player, i tested, all iOs i get this problem, in both browser (Safari and Chrome)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants