Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Windows binaries to release action #7

Open
KevinGimbel opened this issue Apr 17, 2023 · 2 comments
Open

Add Windows binaries to release action #7

KevinGimbel opened this issue Apr 17, 2023 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@KevinGimbel
Copy link
Owner

KevinGimbel commented Apr 17, 2023 •
edited
Loading

Binaries are now build with GitHub Actions (https://github.com/KevinGimbel/mktoc/blob/main/.github/workflows/release.yml), so Windows binaries should be supported alongside Apple and Linux ones.

I know nothing about Windows binaries so I'm unsure which of these targets make sense to build for:

  • x86_64-pc-windows-msvc
  • x86_64-pc-windows-gnu

Maybe all of them?
@KevinGimbel KevinGimbel added enhancement New feature or request help wanted Extra attention is needed labels Apr 17, 2023
@KevinGimbel KevinGimbel added this to the 3.1 milestone Apr 18, 2023
@KevinGimbel KevinGimbel removed this from the 3.1 milestone Apr 25, 2023
@KevinGimbel
Copy link
Owner Author

Removed milestone as this shouldn't block regular releases.

@KevinGimbel
Copy link
Owner Author

According to https://fosstodon.org/@mobiuscog/113113209852718896 i686 is 32bit Windows and can be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KevinGimbel