Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Filter tag shows column name even when no filters applied on that column #665

Open
riteshhub opened this issue Nov 28, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@riteshhub
Copy link

Describe the bug
In Data tab, when you open Filter Rule Settings window for any column and just close the window, the Filters: tag shows the name of the column even when you have filtered anything.

To Reproduce
Steps to reproduce the behavior:

  1. Go to data tab
  2. Click on filter icon for any column. This will open Filter Rule Settings window
  3. Close Filter Rule Settings window without applying any filters.
  4. You can see the column tagged under Filters: (just below data tab)

Expected behavior
If no filters applied on the column, Filters tag should not show the column.

Screenshots
screen-capture

Versions

  • pygwalker version: 0.4.9.13
  • python version: 3.11
  • browser: All

Additional context
I am using pygwalker with Streamlit 1.40.1

@riteshhub riteshhub added the bug Something isn't working label Nov 28, 2024
@ObservedObserver
Copy link
Member

Well, it's actually a empty filter, not a bug, you can edit it later. but if it is an empty filter, it will not effect on the data.

@riteshhub
Copy link
Author

@ObservedObserver Thanks for looking into this. I agree that it is an empty filter and hence not affect the data. But from user's perspective, they think that some kind of filter has been applied on that column, isn't it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants