Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint against approximated constants #573

Open
chriscerie opened this issue Dec 2, 2023 · 0 comments · May be fixed by #574
Open

Lint against approximated constants #573

chriscerie opened this issue Dec 2, 2023 · 0 comments · May be fixed by #574
Labels
A-lints Area: Relating to a lint directly C-enhancement Category: Feature request or improvement

Comments

@chriscerie
Copy link
Collaborator

Should favor constants like math.pi over 3.14. It should also work for both truncated and rounded numbers, so 3.141 and 3.142 should both lint. But 3.143 should not. It should also work for any arbitrary precision.
@chriscerie chriscerie added C-enhancement Category: Feature request or improvement A-lints Area: Relating to a lint directly labels Dec 2, 2023
@chriscerie chriscerie linked a pull request Dec 2, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-lints Area: Relating to a lint directly C-enhancement Category: Feature request or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Lint against approximated constants chriscerie/selene
1 participant
@chriscerie