Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken Docker build #550

Closed
Jarmos-san opened this issue Aug 27, 2023 · 2 comments
Closed

Fix broken Docker build #550

Jarmos-san opened this issue Aug 27, 2023 · 2 comments

Comments

@Jarmos-san
Copy link

This issue intends to track the discussions to fix the broken Docker build. Once the Docker build is fixed #541 can possibly be merged.

On top of it, the current Dockerfile is configured to use and older version of the Rust Docker Image. Ideally, the latest image should be used (see comment) or be able to pass a specific version Rust version using build-time variables. In other words, the Docker image could be built by running the following commands:

docker build --build-arg RUST_VERSION="1.72-slim-buster" .

Running the command above would instruct Docker to use the 1.72-slim-buster version instead of the default 1-alpine version as stated in the Dockerfile below:

# "1-alpine" is the latest Alpine version of the latest version of Rust
ARG RUST_VERSION="1-alpine"

# Utilise multi-stage builds to keep the final image small and efficient
FROM rust:${RUST_VERSION} AS builder

# ... rest of the contents of the Dockerfile

In addition to the source code fixes, the documentations needs to be updated as well for posterity and proper usage of the tools.

@Jarmos-san
Copy link
Author

@Kampfkarren you can link this issue with #549 so that it is automatically closed once that PR is merged?

@Kampfkarren
Copy link
Owner

You could do that with "Closes #550" in your issue 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants