Issues/KUI 1196 show barchart labels #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amirhossein-haerian
requested review from
belanglos,
karlandindrakryggen and
axelbjo
as code owners
|
Looks good to me! |
axelbjo
approved these changes
Jun 20, 2024
belanglos
approved these changes
Jun 20, 2024
|
|
||
| const seasonsStr = seasons.map(season => seasonLib.labelSeason(season, languageIndex)).join(', ') | ||
| return ( | ||
| <Row> | ||
| <Col xs="4" style={{ flex: 'none', width: 'auto', paddingBottom: '20px' }}> | ||
| <label>{translation.statisticsLabels.formLabels.formSubHeaders.year}</label> | ||
| <label>{formSubHeaders.school}</label> | ||
| {`: ${school === 'allSchools' ? statisticsLabels[school] : school}`} |
There was a problem hiding this comment.
I always have a hard time reading ternary operators inline like that. What do you think of extracting that part to something like getSchoolName or something like that?
There was a problem hiding this comment.
We liked the idea and we made the required changes 🚀
…onal state using function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this task me and @axelbjo added the name of each school below each bar in the charts.
After conversation with Joel: