-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/k UI 1601 remove fields #396
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! I added some comments with suggestions on how to adjust the test file. Since the literature is no longer fetched from kopps, it should be excluded form the kopps template. As a result the added parsing of the kopps api mock result wont be needed.
Mistakenly reviewed changes from #405 within this PR. Please ignore above comments, as I will review them separately. |
We maybe need to look Well done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Wait with merging this until we have decided about what to include in release later this week. |
The auto-retrieval of the following fields from Kopps has been removed now. The fields/headings still remained in the course pm, but are empty from the start when you create a new pm.
Möjlighet till komplettering (possibilityToCompletion)
Möjlighet till plussning (possibilityToAddition)
Utrustning (requiredEquipment)