Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/k UI 1601 remove fields #396

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

amirhossein-haerian
Copy link
Contributor

The auto-retrieval of the following fields from Kopps has been removed now. The fields/headings still remained in the course pm, but are empty from the start when you create a new pm.

Möjlighet till komplettering (possibilityToCompletion)

Möjlighet till plussning (possibilityToAddition)

Utrustning (requiredEquipment)

Copy link
Contributor

@allazis allazis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! I added some comments with suggestions on how to adjust the test file. Since the literature is no longer fetched from kopps, it should be excluded form the kopps template. As a result the added parsing of the kopps api mock result wont be needed.

test/unit/memoCtrl.test.js Show resolved Hide resolved
test/unit/memoCtrl.test.js Show resolved Hide resolved
test/unit/memoCtrl.test.js Show resolved Hide resolved
test/unit/memoCtrl.test.js Show resolved Hide resolved
test/unit/memoCtrl.test.js Show resolved Hide resolved
test/unit/memoCtrl.test.js Show resolved Hide resolved
@allazis
Copy link
Contributor

allazis commented Nov 27, 2024

Mistakenly reviewed changes from #405 within this PR. Please ignore above comments, as I will review them separately.

@allazis
Copy link
Contributor

allazis commented Nov 27, 2024

We maybe need to lookmemoCtrl testfile through but we can save it for PR-405

Well done!

Copy link
Contributor

@axelbjo axelbjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@karlandindrakryggen
Copy link
Contributor

Wait with merging this until we have decided about what to include in release later this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants