-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 🐞: Lecture creation and last modified dates incorrect #38
Comments
Reopening this since I reverted the commit. node-gyp seems to crash when building the example repo and I haven no idea why. I'll keep this open until I can figure it out. |
This seems like a possible fix: |
Okay I just tried installing the dependencies nodegit requires and everything seems fine so far. I'll try again later with npm package cache (with cache-key set to cac.config + build.yml in example repo. |
The time cost of installing nodegit is around 6 mins. I should test with npm cache. If it remains slow either way I think removing all unused functionality and native binds may fix it. Not sure tho. |
Describe the bug
Git doesn't store file metadata. The action doesn't have access to the original file system. When it builds, it checks out the content repo. During this checkout process Git creates the files and sets their stat dates to the current moment, not the original, which causes the template to render dates wrong.
Expected behavior
The template should work with correct dates.
Possible fix
Use nodegit to fetch last commit for each document and get the date of that last modification, as well as the first commit the file was created in.
The text was updated successfully, but these errors were encountered: