Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debuginfod: Only download debug info for hot functions #669

Open
Desour opened this issue Jul 28, 2024 · 2 comments
Open

debuginfod: Only download debug info for hot functions #669

Desour opened this issue Jul 28, 2024 · 2 comments

Comments

@Desour
Copy link

Desour commented Jul 28, 2024

Is your feature request related to a problem? Please describe.
The debuginfod integration is great to have! But using hotspot on an application for the first time (or after an upgrade) can take very long, because it has to download sometimes multiple GiBs of debug info. This also uses up some of my disk space.
And most of the libs are not relevant for the performance bottleneck that you want to investigate.

Describe the solution you'd like
Don't download debug info on startup when loading perf data. Instead make it so that the user can rightclick on a function and choose to download the debug info for only that function's binary.

Describe alternatives you've considered
Download the debug info in background, so the user can look at the output earlier, but without function signatures.

Additional context
None

@GitMensch
Copy link
Contributor

I think debuginfo is needed for understanding the stack - in this case perfparser (called by hotspot) needs that up-front...

@milianw
Copy link
Member

milianw commented Aug 14, 2024

unwinding can (sometimes) be done without the stack (given e.g. .eh_frame), but resolving of inline frames won't work. generally, while I understand your request it is extremely hard to implement this properly. patches welcome but don't hold your breath waiting for it to materialize

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants